-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend injection options #1605
Merged
Merged
Extend injection options #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First try at making UTs
* release/1.0: (99 commits) bump up deps fix description add description fix spelling fix(RnNext:Assets): Fix copying assets by providing absolute path fix/macos_export readd device cli option to withRun preset fix(Web:TemplateStarter): Fixing web icon clean code fix tests fix tests clean code change the engine root path definition fix ip input fix(macOS:TemplateStarter): fix template starter icon fix(macOS): Fixing icon for macos by updating renative assets fix registering engine tasks multiple times fix rnv core task option mocks add pair device option add packageReactNativeAndroid tests ...
* release/1.0: 1.0.0-rc.18 add configuresoft dependOn for crypto, fix tar add support for using rnv crypto in integrations
pavjacko
reviewed
Jun 17, 2024
packages/core/src/schema/platforms/fragments/templateAndroid.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/core/jsonSchema/rnv.plugin.json # packages/core/jsonSchema/rnv.templates.json # packages/core/src/schema/platforms/fragments/templateAndroid.ts
pavjacko
approved these changes
Jun 26, 2024
GabrieleKaceviciute
suggested changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GabrieleKaceviciute
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends current injections possibilities also cleans some old very specific injections.
New additions: ios, tvos
templateXcode.AppDelegate_h.appDelegateMethods
Array of strings adds injections to AppDelegate.h interface. Arbitrary code can be written.
e.g.
templateXcode.AppDelegate_mm.appDelegateMethods.custom
Array of strings adds injections to AppDelegate.mm. Arbitrary code can be written.
e.g.
templateXcode.privacyManifests.NSPrivacyAccessedAPITypes
Injections based on apple privacy manifest rules
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api
e.g.
New additions: android, androidtv, firetv
templateAndroid.build_gradle.buildscript.dependencies
templateAndroid.build_gradle.buildscript.repositories
templateAndroid.build_gradle.buildscript.ext
templateAndroid.build_gradle.buildscript.custom
Array of strings adds injections to build.gradle file dependencies, repositories, ext section. Also with
.custom
arbitrary functions can be written in buildscript.e.g.
templateAndroid.build_gradle.buildscript.injectAfterAll
Array of strings adds injections outside buildscript. Arbitrary functions can be written.
e.g.
How to test?
Follow instructions above by adding injections to
renative.json
file or plugin definitions and observe results in relevant files.Related issues
TBA