Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-platform integrations ask to pick a platform #1634

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Single-platform integrations ask to pick a platform #1634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd1eee4
fix unnecessary platform selection
Marius456 Jul 18, 2024
ed019e4
remove check for tasks
Marius456 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/core/src/tasks/taskFinder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,7 @@ export const extractSingleExecutableTask = async (
suitableTasks: RnvTask[],
taskName: string
): Promise<RnvTask | undefined> => {
let hasPlatformAwareTasks = false;
suitableTasks.forEach((v) => {
if (v.platforms) {
hasPlatformAwareTasks = true;
}
});
if (!hasPlatformAwareTasks && suitableTasks.length === 1) {
if (suitableTasks.length === 1) {
return suitableTasks[0];
} else if (suitableTasks.length === 0) {
return undefined;
Expand All @@ -62,7 +56,6 @@ export const extractSingleExecutableTask = async (
// Restart the process now we defined specific platform
await selectPlatformIfRequired();
const newSuitableTasks = findTasksByTaskName(taskName);

if (newSuitableTasks.match.length === 1) {
return newSuitableTasks.match[0];
} else if (newSuitableTasks.match.length > 1) {
Expand Down
Loading