Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running tizen watch emulator not recognized by rnv #703

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

kasinskas
Copy link
Collaborator

Description

rnv was not recognizing running tizen watch emulator and kept asking to create a new one. it was caused by xml formatter expecting completely different object structure returned by xml2js parser and because of that reducing it to {undefined: undefined} here, which in turn caused this condition fail.

This is what was being returned from xml2js -
image

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@kasinskas kasinskas requested a review from pavjacko August 4, 2021 13:31
@pavjacko pavjacko merged commit bcdbca2 into flexn-io:develop Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants