Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/plugins support #721

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Feat/plugins support #721

merged 1 commit into from
Nov 9, 2021

Conversation

mihaiblaga89
Copy link
Contributor

Description

added support form plugins direct dependencies

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing functionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@mihaiblaga89 mihaiblaga89 changed the base branch from develop to feat/engines-merged November 5, 2021 15:26
@codecov-commenter
Copy link

Codecov Report

Merging #721 (2b439a5) into feat/engines-merged (1d35f48) will decrease coverage by 0.06%.
The diff coverage is 6.89%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/engines-merged     #721      +/-   ##
=======================================================
- Coverage                20.47%   20.40%   -0.07%     
=======================================================
  Files                       84       84              
  Lines                     5607     5636      +29     
  Branches                  1246     1252       +6     
=======================================================
+ Hits                      1148     1150       +2     
- Misses                    3340     3361      +21     
- Partials                  1119     1125       +6     
Flag Coverage Δ
rnvunittests 20.40% <6.89%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rnv/src/core/pluginManager/index.js 8.28% <6.89%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d35f48...2b439a5. Read the comment docs.

@pavjacko pavjacko changed the base branch from feat/engines-merged to develop November 9, 2021 20:18
@pavjacko pavjacko merged commit 3255eaf into develop Nov 9, 2021
@pavjacko pavjacko deleted the feat/plugins_support branch November 9, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants