Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree scroll #2593

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Tree scroll #2593

merged 7 commits into from
Jan 28, 2025

Conversation

julien-louis
Copy link
Collaborator

  • auto scroll in tree
  • opening body & equipment nodes wasn't displaying the tree : fixed

@DuckflipXYZ
Copy link
Collaborator

Hi @julien-louis !

The feature works perfectly at first sight. One problem is that it only works once, the page needs to be refreshed for auto scrolling again

Copy link
Collaborator

@DuckflipXYZ DuckflipXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julien-louis ! No need to refresh anymore :)

Last thing is that the autoscroll occurs only when dataset is loaded, which can take close to 1 min on ofsep qualif (within big study). Can you make an autoscroll step at the subject level while dataset is loading ? At least, we should be able to see the gearwheel rotating, as well as having an approximative location of the desired dataset.

If you think that's useless, up to you to merge the PR :)

++

@DuckflipXYZ
Copy link
Collaborator

Nice update +1

@DuckflipXYZ DuckflipXYZ merged commit 49c111d into fli-iam:develop Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants