WIP: iOS refactor #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 12, 2023 21:46
… keep POC methods with original names.
added 19 commits
May 16, 2023 20:16
add header directories to pod spec.
DominikHinc
reviewed
Jun 7, 2023
ios/VydiaRNFileUploader.swift
Outdated
|
|
||
| override public func sendEvent(withName eventName: String, body: Any?) { | ||
| if let emitter = VydiaRNFileUploader.emitter { | ||
| // emitter.sendEvent(withName: eventName, body: body) |
There was a problem hiding this comment.
Of course not :) RN I am dealing with some crashes. Upload itself worked ok without emitter, it goes berserk with emitter...
sxcore
commented
Jun 7, 2023
| } | ||
| s.user_target_xcconfig = { | ||
| "HEADER_SEARCH_PATHS" => "\"${PODS_CONFIGURATION_BUILD_DIR}/react-native-background-upload/Swift Compatibility Header\"", | ||
| } | ||
| s.platform = :ios, "9.0" |
There was a problem hiding this comment.
Maybe we should bump platform to 12.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md