Allow changing of actor or percentage gates in active_record adapter #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that is less than ideal. :( Thanks for the patch. I suspect that disable suffers the same problem. I can fix that up after I merge this. |
jnunemaker
added a commit
that referenced
this pull request
May 12, 2016
refs #122. This takes a bit different approach. Instead of first or initialize by which could race we use a transaction to delete all and create. Instead of still possibly ending up with dups this approach should mean we just let last write win. I think…
|
I tweaked your approach a bit #124. Can't believe I missed that. Thanks for finding and sorry for any pain it caused you and the lost time tracking it down. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choosing a second (or additional) percentage creates an additional row in the feature_gates table. The one that is used is arbitrary, typically the first one created.
Additionally, if a user chooses a percentage for a feature that was previously chosen, this will create an exception.
The fix should work in rails 3.2 and 4.x.