-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import #251
Merged
Merged
Import #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it would be nice to have adapter migrate for when switching from one adapter to another. This makes it so you don't have to write your own migration.
I was passing flipper instead of adapter. This corrects that. Starting to move some spec stuff to shared so I can re-use for new specs I am about to add.
For parody with Feature#remove
I'm not sure if migrate is the right word I want. import feels closer but I still don't love it either.
This is useful when you have a flipper_id and want to pass it into the feature enabled method
Previously it was only dealing with features in the adapter being used as the source of truth. Now all features in adapter are wiped first and then each individual feature is imported.
bundle exec guard was erroring with `bin_path': can't find gem bundler`. Removing the path and re-bundling got it working again. Found that out by reading guard/guard-bundler#32.
Some tests are slow now so let's just run what we have to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking for a while it would be nice to have a way to swap from one adapter to another. This PR makes that easy. It is not super efficient about network calls, but that can be improved later. I wanted to start with easy and correct. Plus, this is something that should happen very rarely, so if it does a few extra network calls, it probably isn't a big deal.
Example