fixes #70

flitbit · Apr 25, 2017 · af99304 · af99304 · lrdevries · Apr 29, 2017
1 parent 5d6df24
commit af99304
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/examples/issue-70.js b/examples/issue-70.js
@@ -0,0 +1,6 @@
+var deepDiff = require("../");
+
+var left = {foo: undefined};
+var right = {};
+
+console.log(deepDiff.diff(left, right));
diff --git a/index.es.js b/index.es.js
@@ -146,6 +146,8 @@ function deepDiff(lhs, rhs, changes, prefilter, path, key, stack) {
   if (ltype === 'undefined') {
     if (rtype !== 'undefined') {
       changes(new DiffNew(currentPath, rhs));
+    } else {
+      changes(new DiffDeleted(currentPath, lhs));
     }
   } else if (rtype === 'undefined') {
     changes(new DiffDeleted(currentPath, lhs));

diff --git a/index.js b/index.js
@@ -153,6 +153,8 @@ function deepDiff(lhs, rhs, changes, prefilter, path, key, stack) {
   if (ltype === 'undefined') {
     if (rtype !== 'undefined') {
       changes(new DiffNew(currentPath, rhs));
+    } else {
+      changes(new DiffDeleted(currentPath, lhs));
     }
   } else if (rtype === 'undefined') {
     changes(new DiffDeleted(currentPath, lhs));

diff --git a/test/tests.js b/test/tests.js
@@ -563,4 +563,24 @@ describe('deep-diff', function() {
             expect(deep.diff(lhs, rhs)).to.be(undefined);
         });
     });
+
+    describe('regression test for issue #70', function() {
+        var lhs = {foo: undefined };
+        var rhs = {}
+
+        it('should detect a difference', function() {
+            var diff = deep.diff(lhs, rhs);
+
+            expect(diff.length).to.be(1);
+
+            expect(diff[0].kind).to.be('D');
+            expect(diff[0].path).to.be.an('array');
+            expect(diff[0].path).to.have.length(1);
+            expect(diff[0].path[0]).to.be('foo');
+            expect(diff[0].lhs).to.be(undefined);
+
+        });
+    });
+
+
 });