-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support py3.6 and py3.9 #26
support py3.6 and py3.9 #26
Conversation
4114d3c
to
f9d9235
Compare
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 319 317 -2
=========================================
- Hits 319 317 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Lots of interesting things in here. I'm thinking of passing these in separate PRs just out of cleanliness and moving this forward without blocking on specific items.
Edit: looks like we can start with #25 which takes this isolated approach nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fab, thanks. 3.6 support is cheap enough (only requiring contextlib2
on 3.6) that I think we can be okay with adding support.
No description provided.