Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use different than mapped type to allow for usage of bigint on int entries #1455

Merged

Conversation

norberttech
Copy link
Member

Change Log

Added

  • DbalMetadata::type - allowing to change the type mapping on a specific column level

Fixed

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.798mb +0.01%  | 555.004ms -0.63% | ±0.22% -26.95%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.871mb +0.01%  | 1.052s -1.08%    | ±0.89% -13.80%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.312mb +0.00% | 911.866ms +0.95% | ±0.69% +101.83% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.528mb +0.01%  | 35.167ms -0.49%  | ±0.35% -63.17%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.502mb +0.01%  | 606.144ms +0.09% | ±0.28% -62.57%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.324mb +0.00% | 69.176ms -3.60% | ±0.77% -42.47% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 63.995mb +0.00%  | 104.330ms +0.68% | ±2.23% +83.14% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.342mb +0.00%  | 98.818ms +1.33%  | ±0.56% +60.68% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.183mb +0.00% | 20.653s -1.20%   | ±0.11% -64.69% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.994mb +0.00%  | 31.670ms +1.42%  | ±0.13% -79.58% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.967mb +0.00% | 457.174ms +0.29% | ±0.68% -44.78%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.158mb +0.00%  | 232.711ms -3.90% | ±0.99% +33.53%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.680mb +0.00%  | 50.902ms -0.52%  | ±0.81% -42.70%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.011mb +0.00%  | 3.580ms -8.54%   | ±0.69% -78.40%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.293mb +0.00% | 185.314ms +0.27% | ±1.52% +40.68%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.013mb +0.00%  | 18.505ms -3.28%  | ±0.85% +215.87% |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.885mb +0.00%  | 1.576ms -22.71%  | ±1.49% -19.67%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.885mb +0.00%  | 1.575ms -16.43%  | ±1.19% -10.28%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.046mb +0.00%  | 4.613ms -14.00%  | ±1.29% +20.51%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.575mb +0.00%  | 16.722ms -0.86%  | ±0.95% +155.34% |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.575mb +0.00%  | 16.805ms -1.80%  | ±1.54% +26.71%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.266mb +0.00%  | 1.994μs -0.30%   | ±2.40% +0.00%   |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.266mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.484mb +0.00% | 15.227ms -2.24%  | ±2.02% -37.34%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.552mb +0.00% | 71.823ms -2.62%  | ±0.68% +51.25%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.095mb +0.00%  | 1.509ms -26.61%  | ±3.46% +445.32% |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.393mb +0.00% | 64.380ms -2.49%  | ±0.72% +13.40%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.148mb +0.00%  | 3.975ms -4.45%   | ±1.04% -58.12%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.555mb +0.00%  | 41.231ms -3.18%  | ±0.88% -17.22%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.555mb +0.00%  | 41.586ms -0.42%  | ±0.64% -34.14%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.555mb +0.00%  | 42.233ms -4.39%  | ±1.52% -15.92%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.707mb +0.00%  | 8.358ms -0.79%   | ±2.62% +182.19% |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.457mb +0.00%  | 29.069ms -0.90%  | ±0.74% -23.33%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.266mb +0.00%  | 13.599μs -1.67%  | ±1.80% +6.72%   |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.266mb +0.00%  | 15.288μs -5.62%  | ±0.62% -71.48%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.294mb +0.00% | 188.064ms -1.35% | ±2.28% +344.22% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.803mb +0.00%  | 365.663ms +0.45% | ±1.07% +27.82%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.612mb +0.00%  | 72.772ms -0.44%  | ±0.60% -25.60%  |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (add4392) to head (910077c).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1455      +/-   ##
==========================================
- Coverage   83.02%   83.01%   -0.01%     
==========================================
  Files         662      662              
  Lines       17816    17820       +4     
==========================================
+ Hits        14791    14794       +3     
- Misses       3025     3026       +1     
Components Coverage Δ
etl 85.73% <ø> (ø)
cli 86.73% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 97.36% <ø> (ø)
lib-filesystem 76.75% <ø> (ø)
lib-parquet 84.33% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 90.69% <ø> (-0.47%) ⬇️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.49% <ø> (ø)
adapter-doctrine 88.68% <90.00%> (+0.14%) ⬆️
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.81% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit 5dbd375 into flow-php:1.x Feb 8, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant