Latest version does not support Angular 15 which results in dependency conflicts for ngx-flow when updating to Angular 15.

[sukantoghsh]

What would be the best approach to solve this ?

[Quentigus]

I need Angular 15 support too 👍

EDIT : NPM overrides work as temporary workaround :

"overrides": {
    "@flowjs/ngx-flow": {
        "@angular/animations": "15",
        "@angular/common": "15",
        "@angular/compiler": "15",
        "@angular/core": "15",
        "@angular/forms": "15",
        "@angular/platform-browser": "15",
        "@angular/platform-browser-dynamic": "15",
        "@angular/router": "15"
    }
}

[evilaliv3]

@sukantoghsh / @Quentigus : which is your experience with Angular15? Did you encounter any incompatibility?

@MartinNuc : which are you evaluations?

[evilaliv3]

Hello @MartinNuc, i just wanted to reming you about this ticket in case you missed to see my comment.

@sukantoghsh @Quentigus: do you confirm that all is working perfectly on the current Angular?

[Quentigus]

I haven't tested everything, no. I was waiting to see if official support would be offered.

[evilaliv3]

Thank you.

Did you encounter any error testing it?

[StavNoyAkur8]

Our project has been working with Angular 15 and ngx-flow since January using legacy-peer-deps. No issues.
Thanks @Quentigus for the tip on NPM overrides

[rmhubley]

What about Angular 16? I am getting this error:

Error: src/app/workbench/workbench.module.ts:53:5 - error NG6002: 'NgxFlowModule' does not appear to be an NgModule class.

53     NgxFlowModule,
       ~~~~~~~~~~~~~

  node_modules/@flowjs/ngx-flow/lib/ngx-flow.module.d.ts:2:22
    2 export declare class NgxFlowModule {
                           ~~~~~~~~~~~~~
    This likely means that the library (@flowjs/ngx-flow) which declares NgxFlowModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Turns out the missing magic was:
update to ngx-flow 0.6.0 and employ the suggestions from another issue (#81):

npm i --save-dev @types/flowjs__flow.js

# Then changed to this import form rather than what the docs say to use
import * as Flow from '@flowjs/flow.js';

[Quentigus]

Is it possible de release a new version with a more permissive peerDependencies ?

For exemple :

"peerDependencies": {
    "@angular/common": ">=14.0.0",
    "@angular/core": ">=14.0.0",
    "@flowjs/flow.js": "^2.13.0"
},

Actual values ("^14.0.0-") seems to be invalid semver values

[CosmoFruit]

fixed #105

[CosmoFruit]

@MartinNuc @AidasK @evilaliv3 Hi, can you publish 0.7.0 release?

[Quentigus]

According to the semver syntax documentation, I think that the syntax is not valid. In my opinion, the "-" should be removed.

"peerDependencies": {
    "@angular/common": "^14.0.0-", // here
    "@angular/core": "^14.0.0-", //here
    "@angular/common": "^16.0.0-", // here 
    "@angular/core": "^16.0.0-", // and here
    "@flowjs/flow.js": "^2.13.0"
},

[evilaliv3]

Thank you for the reminder.

Are you all confident that the version 0.7.0 is working properly?
Can someone confirm this and eventually ensure that the dependencies included in 0.7.0 are up to date and tests working?

I'm not following the project so much but i may try to do the publishing if you could confirm this.

Is there anyone that would like to support the maintainance of the project?

[CosmoFruit]

Is there anyone that would like to support the maintainance of the project?

@evilaliv3 i can support the maintainance of the project, bcz we use it in our enterprise, and we need ability update dependencies

[evilaliv3]

Thank you @CosmoFruit

Would you like to make a pull request in relation to the up to date changes that you consider are needed?
Viewing some contributions would help us all evaluate who could move on with the maintainance of the project on the long run.

[CosmoFruit]

@evilaliv3 ready, all is work fine, updated only compatible deps. will waiting actual release in npm =)

[CosmoFruit]

@evilaliv3 also, can you grant acess to this repo? it would be great to put things in order and close the outdated issues

[CosmoFruit]

@evilaliv3 any updates?

[sebastiencl]

Any news about the npm publication ? I'm stuck with my overrides since more than a year.
0.7.0 would be the perfect gift for christmas :)

[sebastiencl]

@MartinNuc are you here ?

And happy new year of course ;)

[evilaliv3]

O Saturday or Sunday I will try to see if I still have the permission to make the release. I've also to remember how :)

[AidasK]

I have also added @CosmoFruit to the maintainers, maybe he still wants to help :))

[Quentigus]

Hello,
You can add me too, I will try to help 👍

[evilaliv3]

Ive built and published the 0.7.0 on npm.

Would you please test on your projects if the publishing was correct? Thank you

[sebastiencl]

It works great. Thanks a lot !

[evilaliv3]

Is anyone able and interested in supporting the update of the library to angular 17?

[CosmoFruit]

great! thx.

Is anyone able and interested in supporting the update of the library to angular 17?

i will planning do it at this spring. when we will migrated on angular 17

[CosmoFruit]

this issue can be closed

[CosmoFruit]

I have also added @CosmoFruit to the maintainers, maybe he still wants to help :))

can you repeat invite plz ? =)

[evilaliv3]

Is there anyone interested supporting updating the library for Angular 17?

[CosmoFruit]

@evilaliv3 @AidasK can you add me to npm org? i build patch, and want try publish. or can you setup auto publish on release create here https://github.com/flowjs/ngx-flow/blob/master/.github/workflows/npm-publish.yml

[AidasK]

@CosmoFruit what's your npmjs username?

[CosmoFruit]

@CosmoFruit what's your npmjs username?

https://www.npmjs.com/~cfruit

[AidasK]

@evilaliv3 can you add cfruit? It looks like only the owner can do it

[evilaliv3]

I can definitely do it, but ar the moment @CosmoFruit we have already a new package fully supporting Angular 16.

Ars you able to prepare a pull request to add support for Angular 17 ?

[CosmoFruit]

I can definitely do it, but ar the moment @CosmoFruit we have already a new package fully supporting Angular 16.

Ars you able to prepare a pull request to add support for Angular 17 ?

i made litle fix #107 for upgrade DX (avoid --legacy-peer-deps) and i want do (https://github.com/flowjs/ngx-flow/blob/master/.github/workflows/npm-publish.yml) automatical for publish release

[Quentigus]

i made litle fix #107 for upgrade DX (avoid --legacy-peer-deps)

0.7.1 should be published asap :)

[CosmoFruit]

@evilaliv3 @AidasK @MartinNuc can you publish 0.7.1 ?

[evilaliv3]

published @Quentigus @CosmoFruit

Do you have any plans for updating the library to angular 17?

[Quentigus]

I will need, for my work, an Angular 18 version, I can take care of this compatibility upon release.

For v17, I don't have much time at the moment, I'll try but I can't promise anything.

[Quentigus]

I've installed the 0.7.1 version inside my project and seems to be broken :(
This is not a compiled bundle (left = 0.7.0 - right = 0.7.1) :

Error in project (only with 0.7.1 :

[evilaliv3]

Ah, this is probably my fault.

I just run npm publish.

Do you know the commands that i need to run to have a compiled bundle?

[Quentigus]

I don't know the workflow for this package.
The publish must be done on the compiled bundle

[evilaliv3]

Ok unpublished, we will be able to publish the same corrected version after 24 hours

[Quentigus]

Can you add me to the npm org, please ?
https://www.npmjs.com/~quentigus

I can publish the 0.7.1 and migrate to Angular 17

[evilaliv3]

Sure, thank you.

I've just sent you an invite.

I just tried to re-publish the 0.7.1 but actually npm prevents it.
I think you will need to publish a 0.7.2

[Quentigus]

The invitation is for another project : https://www.npmjs.com/package/ngx-flow

EDIT : this is the package created with latest publish (doesn't exists anymore)

[Quentigus]

Can you add me on https://www.npmjs.com/package/@flowjs/ngx-flow ?

[evilaliv3]

@Quentigus : oh sorry, that was a test one. i tried to add you now, have you received the invite?

In the meantime due to the rules of npm that correctly prevents to publish a version already published, i've published a 0.7.2 that fixes the 0.7.1 release

[Quentigus]

The first , yes, but not the second.