Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom hf download cache #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KarryCharon
Copy link

No description provided.

@KarryCharon
Copy link
Author

#28

@KarryCharon KarryCharon changed the title #28 Feature: Custom hf download cache Mar 11, 2024
@flowtyone
Copy link
Owner

@KarryCharon I think this PR is not necessary, please read here and here

Setting the HF_HOME and HF_HUB_CACHE environment variables should have the same effect as the changes you've made

@Yorha4D
Copy link

Yorha4D commented Mar 11, 2024

@flowtyone The situation is like this
A few months ago, ControlNet Aux encountered an issue with caching models from a huggingface, which resulted in the need to download them again every time the cache was executed, even if the model was already prepared locally.
This means that using the huggingface method requires recaching every time, so you have to connect to the huggingface every time, even if there are already files locally.
The current situation should also be the same. The method of using huggingface cannot establish an effective cache, and each time it still needs to be downloaded again. This is also why it is necessary to connect to huggingface every time
Fannovel16/comfyui_controlnet_aux#39

@Yorha4D
Copy link

Yorha4D commented Mar 11, 2024

In fact, these codes are only intended to run offline with cache, rather than downloading files like config.json every time I connect to the huggingface
(Perhaps you can try using it in a network free environment to understand the problem with huggingface)

phr00t pushed a commit to phr00t/ComfyUI-Flowty-TripoSR that referenced this pull request Jun 6, 2024
expose mc resolution; add glb export in gradio ui
# Conflicts:
#	gradio_app.py
#	run.py
@GrayRabbit-FE
Copy link

I tried to use this branch but still failed. Where should I put the local models?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants