Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usage_page parameter to specify device more precisely #202

Closed
wants to merge 1 commit into from

Conversation

glyph
Copy link

@glyph glyph commented May 1, 2023

fixes #200

This may be specific to the Rival 650, or it might be something more general to all SteelSeries mice; I don't have any way to test. Perhaps it should be part of the device profile? All I can say is that without this patch, rivalcfg interacting with my mouse is the luck of the draw; with it, I can reliably get the battery percentage.

I can say that at least it works with both wired & wireless devices.

@flozz
Copy link
Owner

flozz commented May 2, 2023

On which operating system have you tested? macOS?

I will need some time to understand what the usage_page is exactly and if it is also required on other OS and other devices.

I have the Rival 650 so I will be able to test on my own on Linux. :)

@glyph
Copy link
Author

glyph commented May 2, 2023

On which operating system have you tested? macOS?

Yep, macOS only so far. I do have a Windows & Linux VM, and … maybe I can pass through the device on there? Clearly I have not adequately prepared this PR though :)

@flozz
Copy link
Owner

flozz commented May 9, 2023

I think this PR will break Rivalcfg on Linux: usage page is always "0", at least with the hidraw driver :/

#200 (comment)

@flozz
Copy link
Owner

flozz commented May 10, 2023

I will not be able to merge your PR as it breaks Rivalcfg on Linux. But thanks to your PR I have enough information to think about a fix.

I tried something in the 200-macos-ventura-endpoint branch. Can you test if it work?

more: #200 (comment)

@flozz flozz closed this May 10, 2023
@glyph glyph deleted the usage-page branch May 18, 2023 17:57
@glyph
Copy link
Author

glyph commented May 18, 2023

Yeah this PR was more of a sketch anyway; I appreciate your prompt investigation here and I'm glad that my poking around helped a little bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requested device or endpoint not found: 1038:183a:03 on MacOS Ventura
2 participants