Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Allow redeclaring services (and abilities) [LNG-360] #1135

Merged
merged 7 commits into from
May 10, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented May 7, 2024

Description

Add support for redeclaring imported services in an aqua module.
Example:
import1.aqua:

aqua Import1 declares Srv

service Srv("srv-id"):
  call()

import2.aqua:

aqua Import2 declares Import1.Srv

use "import1.aqua"

main.aqua:

aqua Main

export main

use "import2.aqua"

func main():
  Import2.Import1.Srv.call()

Implementation Details

Gather all services in AquaContext to pass them to FuncRaw.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented May 7, 2024

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label May 8, 2024
@InversionSpaces
Copy link
Contributor Author

@DieMyst Note that important changes are allServices in AquaContext and .reverse in ValuesAlgebra. Everything else is tests or refactor.

@InversionSpaces InversionSpaces requested a review from DieMyst May 8, 2024 13:23
@InversionSpaces InversionSpaces changed the title feat(compiler): Allow redeclaring services [LNG-360] feat(compiler): Allow redeclaring services (and abilities) [LNG-360] May 8, 2024
@InversionSpaces InversionSpaces merged commit faf5b80 into main May 10, 2024
11 of 15 checks passed
@InversionSpaces InversionSpaces deleted the feat/LNG-360-services-redeclaration branch May 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants