-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): Allow renaming imports with qualified names [LNG-361] #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InversionSpaces
force-pushed
the
feat/LNG-361-imports-renaming
branch
from
May 15, 2024 06:41
9a3a259
to
66f0699
Compare
InversionSpaces
force-pushed
the
feat/LNG-361-imports-renaming
branch
from
May 20, 2024 09:24
b39dd68
to
b9cf0f5
Compare
DieMyst
reviewed
Jul 3, 2024
DieMyst
reviewed
Jul 3, 2024
|
DieMyst
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor internal aqua module management.
Allow users redeclare whole modules, e.g.
declares all
Lib.SubLib.*
symbols.Allow renaming nested symbols when importing, e.g.
Allow exporting nested imported symbols, e.g.
Proposed Changes
RawContext
handling. Now abilities are "linearized" meaning that abilityA.B.C
is stored in nested abilitiesA
,B
andC
. Previously it was stored just under key"A.B.C"
Implementation Details
SName
(simple name, without dots) andPName
(path name that may contain dots) are introduced to substituteString
s and tighten typingChecklist
Reviewer Checklist