fix(CapacityInfo): fix not found link to capacities #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shamsartem
reviewed
Nov 8, 2024
shamsartem
reviewed
Nov 8, 2024
src/pages/offer/PeersTable.tsx
Outdated
Comment on lines
88
to
91
| {peer.currentCapacityCommitment?.status && ( | ||
| <CapacityStatus | ||
| status={peer.currentCapacityCommitment?.status} | ||
| /> |
There was a problem hiding this comment.
maybe there should be a - like above in case there is no peer.currentCapacityCommitment
or there should be no - above. Would be nice to be at least consistent with how missing values look in UI
There was a problem hiding this comment.
I have updated the code in this file to ensure consistent handling of missing values. Moving forward, I will apply this practice across other relevant sections to maintain uniformity
shamsartem
reviewed
Nov 8, 2024
src/pages/offer/PeersTable.tsx
Outdated
| {/* Compute units */} | ||
| <Cell> | ||
| <Text size={12}>{peer.computeUnits.length}</Text> | ||
| </Cell> | ||
| {/* Current Capacity Commitment */} | ||
| {/* Status */} |
There was a problem hiding this comment.
I would just remove this. Serves no purpose
Suggested change
| {/* Status */} |
There was a problem hiding this comment.
I agree that such comments are likely redundant and can be removed throughout the codebase
shamsartem
approved these changes
Nov 8, 2024
Co-authored-by: shamsartem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.