feat(storage): move state to persistent storage #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
changed the title
gurinderu
force-pushed
the
feature/net-759
branch
from
4c6a042 to
8e95f27
Compare
folex
reviewed
Feb 23, 2024
| @@ -55,6 +55,7 @@ jobs: | |||
| - snapshot | |||
| uses: fluencelabs/nox/.github/workflows/build.yml@master | |||
| with: | |||
| ref: feature/net-759 | |||
There was a problem hiding this comment.
i guess this changes nothing, right
There was a problem hiding this comment.
It uses a modified nox
folex
reviewed
Feb 23, 2024
| @@ -92,6 +93,7 @@ jobs: | |||
|
|
|||
| uses: fluencelabs/nox/.github/workflows/tests.yml@master | |||
| with: | |||
| ref: feature/net-759 | |||
folex
reviewed
Feb 23, 2024
| @@ -212,17 +214,20 @@ mod tests { | |||
|
|
|||
| /// after_each macro copy-pastes this function into every test | |||
| fn after_each() { | |||
| std::fs::remove_file(DB_FILE).ok(); | |||
| // std::fs::remove_file(DB_FILE).ok(); | |||
folex
reviewed
Feb 23, 2024
| use marine_rs_sdk_test::marine_test; | ||
|
|
||
| use crate::schema::DB_FILE; | ||
| const DB_FILE: &str = "./tests_artifacts/spell.sqlite"; |
folex
reviewed
Feb 23, 2024
| use marine_rs_sdk_test::marine_test; | ||
| use serde_json::json; | ||
|
|
||
| use crate::schema::DB_FILE; | ||
| const DB_FILE: &str = "./tests_artifacts/spell.sqlite"; |
folex
reviewed
Feb 23, 2024
| @@ -6,11 +6,10 @@ set -o pipefail | |||
|
|
|||
| cd "$(dirname "$0")" | |||
|
|
|||
| rm -f /tmp/spell.sqlite | |||
There was a problem hiding this comment.
yep, it is not inside wasm runtime, and I don't see any interaction with the /tmp dir outside
kmd-fl
approved these changes
Feb 23, 2024
| @@ -319,37 +330,37 @@ mod tests { | |||
| let cp = || host_call_params(); | |||
|
|
|||
| type SPELL = marine_test_env::spell::ModuleInterface; | |||
| let set_str_ok = |spell: &mut SPELL, key: &str, value: &str| { | |||
There was a problem hiding this comment.
that's ridiculous, why idea didn't do it for me, lol
|
|
||
| use crate::schema::DB_FILE; | ||
| const DB_FILE: &str = "./tests_artifacts/spell.sqlite"; |
There was a problem hiding this comment.
why don't import it? how does it work now?
There was a problem hiding this comment.
crate::schema::DB_FILE is a file inside the wasm runtime, DB_FILE is a file in the current system
folex
pushed a commit
that referenced
this pull request
Feb 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.4](spell-v0.7.3...spell-v0.7.4) (2024-02-23) ### Features * **storage:** move state to persistent storage ([#277](#277)) ([ae9ac0d](ae9ac0d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.