build: Use /W4 instead of /Wall on MSVC #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that /Wall is too much verbose on Windows, giving us a lot of unhelpful feedbacks. Now, the official VC++ manual recommends to use /W4. Let's just switch to it. > We recommend that you use this option to provide lint-like warnings. > For a new project, it may be best to use /W4 in all compilations; > this will ensure the fewest possible hard-to-find code defects. > > https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level Signed-off-by: Fujimoto Seiji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that /Wall is too much verbose on Windows, giving us a
lot of unhelpful feedbacks.
Now, the official VC++ manual recommends to use /W4. Let's just switch
to it.
Main issue link: fluent/fluent-bit#960