-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: Add descriptions for x509v3 alt name verification (tls.verify_hostname) #1393
Conversation
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we default to not verifying the alternative name? This seems counter to an expectation of secure by default.
administration/transport-security.md
Outdated
@@ -9,6 +9,7 @@ Both input and output plugins that perform Network I/O can optionally enable TLS | |||
| :--- | :--- | :--- | | |||
| tls | enable or disable TLS support | Off | | |||
| tls.verify | force certificate validation | On | | |||
| tls.verify\_hostname | force hostname validation for certificates | Off | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly different wording to below.
Co-authored-by: Pat <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
Once, I implemented this feature as a forcibly style, I just though such way. Because hostname verification is mostly required for TLS connections to prevent malformed hostname attached instances. However, we got realized that there is many issues in certificates for kubelet. So, preserving the backward compatibilities, we need to disable by default. |
Is this just to handle kubelet specific things then? I'd expect tls verify for everything else, e.g. outputs, etc., so can we just add a special config for kubelet usage to disable it? |
Hmm.., I see. For 3.x line, we need to restore the behavior. But it's reasonable to verify certificates as much as possible in 3.1. |
Oh, merged my PRs as-is. Also, users complains in in_forward and filter_kubernetes. This is because our network stack is not dumped for its error status with human readable errors. So, we need to restore the behavior. For TLS client, we can print the error message from OpenSSL's certificate verification. But, for server, we didn't get how to print an error with human readable modifications. |
Corresponding to fluent/fluent-bit#8966.