out_stackdriver: Port out_stackdriver to Windows #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a set of fixes that make out_stackdriver compilable and runnable on Windows. - Add a prefix "FLB_STD" to each global constant. Since MSVC has a global variable `ERROR`, conflicts occur without the prefix. - Define the S_ISLNK macro for Windows. This feature was requested by Joey DeStefanis and Barni S. Signed-off-by: Fujimoto Seiji <[email protected]>
|
Resolves #1603. |
|
@heartrobotninja Now |
|
Awesome, I will likely deploy tomorrow and let you know how things go. Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a set of fixes that make out_stackdriver compilable
and runnable on Windows.
Add a prefix "FLB_STD" to each global constant. Since MSVC has
a global variable
ERROR, conflicts occur without the prefix.Define the S_ISLNK macro for Windows.
This feature was requested by Joey DeStefanis and Barni S.
Signed-off-by: Fujimoto Seiji [email protected]
Testing
Documentation