Enable PDB generation on Windows build #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean Fausett pointed out that the current Windows release does
not include a debug symbol file. This makes it hard for our
users to analyze a crash dump.
This commit enables the PDB generation, and teaches CMake to
include the symbol file into the release distribution.
td-agent-bit-1.5.0-win32/bin/
- fluent-bit.dll
- fluent-bit.exe
- fluent-bit.pdb
Signed-off-by: Fujimoto Seiji <[email protected]>
CMake creates an enormous number of files. Due to this, the
Windows build on CI is exceptionally slow, in particular,
with Visual Studio project files.
We can mitigate the slowness by using NMake instead.
BEFORE
Platform: Win32 ...... 16 min 16 sec
Platform: x64 ...... 16 min 47 sec
AFTER
Platform: Win32 ...... 8 min 6 sec
Platform: x64 ...... 7 min 4 sec
Signed-off-by: Fujimoto Seiji <[email protected]>
|
Note: We used this PDB file in the investigation of #2251. It did point out I believe it deserves well to be included in the future releases. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sean Fausett pointed out that the current Windows release does
not include a debug symbol file. This makes it hard for our
users to analyze a crash dump.
This commit enables the PDB generation, and teaches CMake to
include the symbol file into the release distribution.