fix a segmentation fault issue in logging worker #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean Fausett reported an out-of-bounds read in log_push() on Windows. Evidently `log_message` struct can be corrupted in some cases, and it confuses the subsequent write() to overrun the buffer. This fixes up the crash issue with a safety check: ensure that msg->size does not exceeds the message buffer size. Signed-off-by: Fujimoto Seiji <[email protected]>
The current logic assumes that read(2) never does a partial read on a certain condition. This is really not guaranteed by POSIX, and indeed not the case on Windows. Use flb_pipe_write_all() and flb_pipe_write_all() to avoid partial I/O in a portable manner. Signed-off-by: Fujimoto Seiji <[email protected]>
This adds missing return paths to these functions, so that they can exit immdeidately if any IO operation fails with -1. Without this, these function can enter into a bogus infnite loop, repeatedly adding -1 to the total byte count. Signed-off-by: Fujimoto Seiji <[email protected]>
fujimotos
changed the title
|
thanks |
This was referenced Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic assumes that read(2) never does a partial read
on a certain condition. This is really not guaranteed by POSIX,
and indeed not the case on Windows.
Use flb_pipe_write_all() and flb_pipe_write_all() to avoid partial
I/O in a portable manner.
Note: This patch is a joint efffort with @gitfool. It is verified to fix
random memory crash issue #2251 on WIndows.