Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add support for jemalloc page size config #5020

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Mar 8, 2022

Fixes #4270 by specifying the page size explicitly for CentOS 7/8 ARM 64 builds.
This only covers the build changes, I still want to resolve the testing side but best to get a fix in now.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Patrick Stephens <[email protected]>
@patrick-stephens patrick-stephens force-pushed the 4270_page_size_arm_rhel branch from 04004b1 to 86cff9b Compare March 8, 2022 16:29
@patrick-stephens patrick-stephens marked this pull request as ready for review March 8, 2022 17:07
Copy link
Collaborator

@niedbalski niedbalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-stephens patrick-stephens temporarily deployed to integration March 8, 2022 18:46 Inactive
@patrick-stephens patrick-stephens temporarily deployed to integration March 8, 2022 18:50 Inactive
@niedbalski niedbalski merged commit 5ca1c93 into master Mar 8, 2022
@niedbalski niedbalski deleted the 4270_page_size_arm_rhel branch March 8, 2022 19:26
mgeriesa pushed a commit to mgeriesa/fluent-bit that referenced this pull request Oct 25, 2022
* cmake: add support for jemalloc page size config

Signed-off-by: Patrick Stephens <[email protected]>

* cmake: make all options configurable

Signed-off-by: Patrick Stephens <[email protected]>
Signed-off-by: Manal Geries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux packages not working for centos (aarch64 / arm64v8)
2 participants