Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_podman_metrics: Added image label #7295

Merged
merged 1 commit into from
May 2, 2023

Conversation

pabloxxl
Copy link
Contributor

@pabloxxl pabloxxl commented May 1, 2023

Added "image" label to all container metrics - it points to container image used by referenced container. Also, added new unit test which checks if out-of-order fields in json configuration file still work.

This is done mostly to be more consistent with cadvisor container metrics. In case of image missing in podman json config (I can't really see why it could happen), this label will point to "unknown"


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found
    valgrind.txt - unit tests with valgrind on

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Added "image" label to all container metrics - it points to
container image used by referenced container. Also, added
new unit test which checks if out-of-order fields in json
configuration file still work.

Signed-off-by: Paweł Cendrzak <[email protected]>
@pabloxxl pabloxxl temporarily deployed to pr May 1, 2023 21:16 — with GitHub Actions Inactive
@pabloxxl pabloxxl temporarily deployed to pr May 1, 2023 21:16 — with GitHub Actions Inactive
@pabloxxl pabloxxl temporarily deployed to pr May 1, 2023 21:17 — with GitHub Actions Inactive
@pabloxxl pabloxxl temporarily deployed to pr May 1, 2023 21:37 — with GitHub Actions Inactive
@edsiper edsiper merged commit bdcaec2 into fluent:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants