-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_emitter: added automatic threading detection workaround #7450
Merged
leonardo-albertovich
merged 5 commits into
master
from
leonardo-master-processor-emitter-thread-safety-workaround
May 21, 2023
Merged
in_emitter: added automatic threading detection workaround #7450
leonardo-albertovich
merged 5 commits into
master
from
leonardo-master-processor-emitter-thread-safety-workaround
May 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
May 20, 2023 17:44
This patch uses the scheduler instance from the thread local storage to determine if the filter creating the emitter instance is running in an input plugins thread to transparently switch over to the ring buffer based mechanism. This is not a definitive solution, it's a workaround. Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
force-pushed
the
leonardo-master-processor-emitter-thread-safety-workaround
branch
from
May 21, 2023 09:59
a6955c2
to
d697739
Compare
Additionally, the unnecessary allocation was removed. Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
deleted the
leonardo-master-processor-emitter-thread-safety-workaround
branch
May 21, 2023 11:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the scheduler instance from the thread local storage to determine if the filter creating the emitter instance is running in an input plugins thread to transparently switch over to the ring buffer based mechanism.
This is not a definitive solution, it's a workaround.