Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: enable sarif output for CIFuzz #7630

Merged

Conversation

DavidKorczynski
Copy link
Contributor

This will make it easier to interpret the output of CIFuzz by making it possible to view the result in the Github security page.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

This will make it easier to interpret the output of CIFuzz by making it
possible to view the result in the Github security page.

Signed-off-by: David Korczynski <[email protected]>
@patrick-stephens patrick-stephens merged commit 0042486 into fluent:master Jul 3, 2023
@nokute78
Copy link
Collaborator

nokute78 commented Jul 8, 2023

@nokute78 nokute78 mentioned this pull request Jul 8, 2023
@jonathanmetzman
Copy link

Very weird, this has worked in the past. I have a fix here: google/oss-fuzz#10673

@nokute78
Copy link
Collaborator

nokute78 commented Jul 9, 2023

Hmm, CI Fuzz detected some errors before merging this patch and they were ignored.
e.g. https://github.com/fluent/fluent-bit/actions/runs/5422155812/jobs/9858454501?pr=7627#step:5:91

This patch may have made it detectable.

@DavidKorczynski
Copy link
Contributor Author

Hmm, CI Fuzz detected some errors before merging this patch and they were ignored. e.g. https://github.com/fluent/fluent-bit/actions/runs/5422155812/jobs/9858454501?pr=7627#step:5:91

This patch may have made it detectable.

I don't see an issue in that run? I think the last time CIFuzz detected and issue is here #7613 and this was due to a bug (fix mentioned in #7613 (comment) )

@jonathanmetzman
Copy link

jonathanmetzman commented Jul 10, 2023

Should be fixed google/oss-fuzz#10673

joshuabaird pushed a commit to joshuabaird/fluent-bit that referenced this pull request Jul 11, 2023
Note: This PR is a backport of fluent#7630

This PR makes in_elasticsearch honor the tag setting.

Signed-off-by: Hiroshi Hatake <[email protected]>
@nokute78
Copy link
Collaborator

@jonathanmetzman @DavidKorczynski Thank you for comment.

Recent CI Fuzz didn't report an error. It is fixed.
e.g. https://github.com/fluent/fluent-bit/actions/runs/5549017264/jobs/10132615553

leonardo-albertovich pushed a commit that referenced this pull request Jul 17, 2023
* workflows: enable sarif output for CIFuzz

This will make it easier to interpret the output of CIFuzz by making it
possible to view the result in the Github security page.

Signed-off-by: David Korczynski <[email protected]>

* workflows: cifuzz: add sarif category

Signed-off-by: David Korczynski <[email protected]>

---------

Signed-off-by: David Korczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants