Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: throw an error if a configuration property is not applied. #7783

Merged
merged 2 commits into from
Aug 18, 2023
Merged

config: throw an error if a configuration property is not applied. #7783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ae99d9
config: throw an error if a configuration property is not applied.
pwhelan Aug 2, 2023
7f3dfb9
config: update comment about setting ret to -1.
pwhelan Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/flb_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,11 @@ static int configure_plugins_type(struct flb_config *config, struct flb_cf *cf,
continue;
}

/* set ret to -1 to ensure that we treat any unhandled plugin or
* value types as errors.
*/
ret = -1;

if (type == FLB_CF_CUSTOM) {
if (kv->val->type == CFL_VARIANT_STRING) {
ret = flb_custom_set_property(ins, kv->key, kv->val->data.as_string);
Expand Down