Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_stackdriver: test_log_entry_format will output log entries to stdout #8144

Merged

Conversation

avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Nov 7, 2023

Adding new config boolean parameter "test_log_entry_format", if true, all requests sent to Google Cloud Logging will be printed to standard output instead.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
[OUTPUT]
  Name        stackdriver
  Match       …
  test_log_entry_format True
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found
    valgrind --leak-check=full ./fluent-bit --conf=<path>
==3512885== 
==3512885== HEAP SUMMARY:
==3512885==     in use at exit: 0 bytes in 0 blocks
==3512885==   total heap usage: 8,287 allocs, 8,287 frees, 1,928,300 bytes allocated
==3512885== 
==3512885== All heap blocks were freed -- no leaks are possible
==3512885== 
==3512885== For lists of detected and suppressed errors, rerun with: -s
==3512885== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary comments…

plugins/out_stackdriver/stackdriver.c Outdated Show resolved Hide resolved
plugins/out_stackdriver/stackdriver.c Outdated Show resolved Hide resolved
plugins/out_stackdriver/stackdriver.c Show resolved Hide resolved
Signed-off-by: avilevy <[email protected]>
Signed-off-by: avilevy <[email protected]>
Signed-off-by: avilevy <[email protected]>
Signed-off-by: avilevy <[email protected]>
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants