-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove linux/s390x smoke tests #8151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With s390x LUA plugin is disabled but smoke tests contain LUA filter so it leads to failure. PR removes the s390x from smoke tests matrix Signed-off-by: Celalettin Calis <[email protected]>
celalettin1286
requested review from
niedbalski and
patrick-stephens
as code owners
November 9, 2023 12:31
Thank you for the PR.
tried curling various endpoints and looks good.
Do you think we can create a separate config for s390x to run |
3 tasks
thanks @ajaypvictor , I discussed the options before creating a PR with @patrick-stephens and decided on removing the test. |
franciscovalentecastro
pushed a commit
to franciscovalentecastro/fluent-bit
that referenced
this pull request
Nov 27, 2023
With s390x LUA plugin is disabled but smoke tests contain LUA filter so it leads to failure. PR removes the s390x from smoke tests matrix Signed-off-by: Celalettin Calis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With s390x LUA plugin is disabled but smoke tests contain LUA filter so it leads to failure. PR removes the s390x from smoke tests matrix
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.