Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove linux/s390x smoke tests #8151

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

celalettin1286
Copy link
Contributor

With s390x LUA plugin is disabled but smoke tests contain LUA filter so it leads to failure. PR removes the s390x from smoke tests matrix


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

With s390x LUA plugin is disabled but smoke tests contain LUA filter so it leads to failure. PR removes the s390x from smoke tests matrix

Signed-off-by: Celalettin Calis <[email protected]>
@ajaypvictor
Copy link
Contributor

Thank you for the PR.
I tried the following config on s390x without lua filter.

[SERVICE]
    HTTP_Server  On
    HTTP_Listen  0.0.0.0
    HTTP_PORT    2020
    Health_Check On
    HC_Errors_Count 5
    HC_Retry_Failure_Count 5
    HC_Period 5
    Log_level debug

[INPUT]
    Name random
    Tag test
    Samples 10

[OUTPUT]
    Name stdout
    Match *

tried curling various endpoints and looks good.

curl -v localhost:"$LOCAL_PORT"                 | jq
*   Trying 127.0.0.1:2020...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Connected to localhost (127.0.0.1) port 2020 (#0)
> GET / HTTP/1.1
> Host: localhost:2020
> User-Agent: curl/7.81.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Server: Monkey/1.7.2
< Date: Thu, 09 Nov 2023 12:44:58 GMT
< Transfer-Encoding: chunked
< Content-Type: application/json
<
{ [806 bytes data]
100   794    0   794    0     0   410k      0 --:--:-- --:--:-- --:--:--  775k
* Connection #0 to host localhost left intact
{
  "fluent-bit": {
    "version": "2.2.0",
    "edition": "Community",
    "flags": [
      "FLB_HAVE_SYS_WAIT_H",
      "FLB_HAVE_IN_STORAGE_BACKLOG",
      "FLB_HAVE_CHUNK_TRACE",
      "FLB_HAVE_PARSER",
      "FLB_HAVE_RECORD_ACCESSOR",
      "FLB_HAVE_STREAM_PROCESSOR",
      "FLB_HAVE_TLS",
      "FLB_HAVE_OPENSSL",
      "FLB_HAVE_METRICS",
      "FLB_HAVE_AWS",
      "FLB_HAVE_AWS_CREDENTIAL_PROCESS",
      "FLB_HAVE_SIGNV4",
      "FLB_HAVE_SQLDB",
      "FLB_LOG_NO_CONTROL_CHARS",
      "FLB_HAVE_METRICS",
      "FLB_HAVE_HTTP_SERVER",
      "FLB_HAVE_SYSTEMD",
      "FLB_HAVE_SYSTEMD_SDBUS",
      "FLB_HAVE_FORK",
      "FLB_HAVE_TIMESPEC_GET",
      "FLB_HAVE_GMTOFF",
      "FLB_HAVE_UNIX_SOCKET",
      "FLB_HAVE_LIBYAML",
      "FLB_HAVE_ATTRIBUTE_ALLOC_SIZE",
      "FLB_HAVE_PROXY_GO",
      "FLB_HAVE_JEMALLOC",
      "FLB_HAVE_LIBBACKTRACE",
      "FLB_HAVE_REGEX",
      "FLB_HAVE_UTF8_ENCODER",
      "FLB_HAVE_ACCEPT4",
      "FLB_HAVE_INOTIFY",
      "FLB_HAVE_GETENTROPY",
      "FLB_HAVE_GETENTROPY_SYS_RANDOM"
    ]
  }
}
curl -v localhost:"$LOCAL_PORT"/api/v1/metrics  | jq
*   Trying 127.0.0.1:2020...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Connected to localhost (127.0.0.1) port 2020 (#0)
> GET /api/v1/metrics HTTP/1.1
> Host: localhost:2020
> User-Agent: curl/7.81.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Server: Monkey/1.7.2
< Date: Thu, 09 Nov 2023 12:45:40 GMT
< Transfer-Encoding: chunked
< Content-Type: application/json
<
{ [202 bytes data]
100   198    0   198    0     0    99k      0 --:--:-- --:--:-- --:--:--  193k
* Connection #0 to host localhost left intact
{
  "input": {
    "random.0": {
      "records": 0,
      "bytes": 0
    }
  },
  "filter": {},
  "output": {
    "stdout.0": {
      "proc_records": 0,
      "proc_bytes": 500,
      "errors": 0,
      "retries": 0,
      "retries_failed": 0,
      "dropped_records": 0,
      "retried_records": 0
    }
  }
}
curl -v localhost:"$LOCAL_PORT"/api/v1/uptime   | jq
*   Trying 127.0.0.1:2020...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Connected to localhost (127.0.0.1) port 2020 (#0)
> GET /api/v1/uptime HTTP/1.1
> Host: localhost:2020
> User-Agent: curl/7.81.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Server: Monkey/1.7.2
< Date: Thu, 09 Nov 2023 12:45:56 GMT
< Transfer-Encoding: chunked
< Content-Type: application/json
<
{ [113 bytes data]
100   102    0   102    0     0  58452      0 --:--:-- --:--:-- --:--:--   99k
* Connection #0 to host localhost left intact
{
  "uptime_sec": 502,
  "uptime_hr": "Fluent Bit has been running:  0 day, 0 hour, 8 minutes and 22 seconds"
}
curl -v localhost:"$LOCAL_PORT"/api/v1/health
*   Trying 127.0.0.1:2020...
* Connected to localhost (127.0.0.1) port 2020 (#0)
> GET /api/v1/health HTTP/1.1
> Host: localhost:2020
> User-Agent: curl/7.81.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Server: Monkey/1.7.2
< Date: Thu, 09 Nov 2023 12:46:13 GMT
< Transfer-Encoding: chunked
<
ok
* Connection #0 to host localhost left intact

Do you think we can create a separate config for s390x to run smoke-tests..

@celalettin1286
Copy link
Contributor Author

thanks @ajaypvictor , I discussed the options before creating a PR with @patrick-stephens and decided on removing the test.

@patrick-stephens patrick-stephens merged commit 281aea0 into master Nov 10, 2023
17 checks passed
@patrick-stephens patrick-stephens deleted the remove-s390x-smoke-tests branch November 10, 2023 14:47
franciscovalentecastro pushed a commit to franciscovalentecastro/fluent-bit that referenced this pull request Nov 27, 2023
With s390x LUA plugin is disabled but smoke tests contain LUA filter so it leads to failure. PR removes the s390x from smoke tests matrix

Signed-off-by: Celalettin Calis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants