mp: new API to convert between msgpack and CFL object #8518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Looking forward to improve how do we manipulate msgpack buffers, we aim to operate on top of the new CFL object structure and reduce the number of serializations required, plus decrease the complexity of the logic in certain plugins that requires several modifcation operations. This patch implements 2 new API calls and test case for: - Convert from MessagePack Object (unpacked) to CFL object - Convert from CFL object to MessagePack buffer (serialized) In the next patches we will extend Log processors by using this new interface. Signed-off-by: Eduardo Silva <[email protected]>
edsiper
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes 2 primary things:
Looking forward to improve how do we manipulate msgpack buffers, we aim to operate on top of the new CFL object structure and reduce the number of serializations required, plus decrease the complexity of the logic in certain plugins that requiresseveral modification operations.
In the next patches we will extend Log processors by using this new interface.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.