in_forward: Implement handshake protocol #8561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-handshake-in_forward
branch
from
94598f0 to
21e5733
Compare
cosmo0920
force-pushed
the
cosmo0920-handshake-in_forward
branch
from
21e5733 to
5656d84
Compare
Handshake process on in_forward in Fluent Bit is: 1. send HELO (FW_HANDSHAKE_HELO) 2. check PING (none) 3. send PONG (FW_HANDSHAKE_PINGPONG) 4. Mark a connect as established (FW_HANDSHAKE_ESTABLISHED) 5. Process retrived records On waiting the actual records, we just early return from the event handler to wait the next read event for ingested logs. Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-handshake-in_forward
branch
from
5656d84 to
59326a1
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
Hello @cosmo0920 I tested this implementation and worked with Classic and YAML format: YAML config: Classic: Fluentd forwarder config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In forward protocol, there is a definition for handshake.
When using out_forward on Fluentd with
<security>directive(s), out_forward on Fluentd hangs due to Fluent Bit didn't implement handshake protocol on its in_forward.This PR aims to implement handshake protocol.
but I didn't implement user authentication part yet.User authentication is also implemented in this PR.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
The self signed certificate is created by the following:
And using Fluentd with its configuration:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.