engine_dispatch: remove chunks from memory if the task fails to be created #8681
Conversation
Signed-off-by: seblaz <[email protected]> (cherry picked from commit bf856d1)
…eated When the tasks_map is filled and the new arriving chunks try to create a new task, then an error is returned. Additionally, under that condition the new chunks don't get deleted from memory, and they occupy a space of the storage.max_chunks_up. Eventually, the new chunks end up using the entire space of the storage.max_chunks_up. This causes the old chunks that have a task assigned to be unable to be brought up into memory, and therefore they never get flushed. This pr fixes the problem by deleting the new chunks from memory in case they failed to create a task and the filesystem storage is in use. Additionally, it runs a check to not bring it up to memory in the first place if possible. Signed-off-by: seblaz <[email protected]> (cherry picked from commit 5a7bbdf)
seblaz
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
@edsiper Any ETA for 2.2.4 release? |
|
Hey there, this change likely introduced a regression. During this time, the input pulls up chunks, and tries to create tasks for them. Because the tasks are full, it can't create any tasks, but leaves these chunks in memory. The engine continually retries the output tasks, but since there is no free memory, it can't pull any chunks up. So: I was able to resolve this issue by giving outputs a small virtual memory reserve that the input doesn't have access to, allowing them to always be able to bring up at least one chunk into memory. This breaks the deadlock, allows the resources to be cleared, and allows the operation to proceed. |
When a task is not created and the filesystem storage is used, then set the chunk down
Fixes #8395 #7329 #5485 #5217
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.