-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_elasticsearch: Process error information properly #9236
out_elasticsearch: Process error information properly #9236
Conversation
The current out_elasticsearch implementation is just giving up to process responses when encountering the error information. In this patch, continue to process until the end of the elements of msgpack converted JSON response. If there is a succeeded infrmation in the converted response, Fluent Bit will assume the requesting payloads to be succeeded to send ES clusters. Signed-off-by: Hiroshi Hatake <[email protected]>
thanks for the PR. this lead me to think in output response testing: #9260 , because we don't have one yet. in addition to that, is this issue also present in our OpenSearch connector ? |
Yes, it should be existing the same possible issue. |
Seeing this issue on both OpenSearch 1.3.x and 2.13.x hosted in AWS with the ES and OS connector. Let me know if I can help in any way. |
The current out_elasticsearch implementation is just giving up to process responses when encountering the error information. In this patch, continue to process until the end of the elements of msgpack converted JSON response.
If there is a succeeded information in the converted response, Fluent Bit will assume the requested payloads to be succeeded to send ES clusters.
Another solution to fix #6341.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.