Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_calyptia_fleet: fix registering agent after first invocation. #9516

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Oct 23, 2024

Summary

Fix a bug where calyptia fleet agents will not correctly register after the first time it is run.

Description

The calyptia fleet plugin stores the initial configuration that is used to invoke fluent-bit inside a file called header.conf (it only stores the configuration for the custom calyptia plugin) and makes use of it in further executions. The plugin also resolves the fleet_name into a fleet_id. This fleet_id though is not known on further executions and due to how it is resolved it would never be resolved in time to register the agent on subsequent executions.

THis fix simply adds the fleet_id to this header.conf so it can be used in subsequent executions beyond the first so it can register fluent-bit with the calyptia frontend.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan requested a review from edsiper October 23, 2024 14:58
@edsiper edsiper added this to the Fluent Bit v3.2.0 milestone Nov 7, 2024
@edsiper edsiper merged commit e039c56 into master Nov 7, 2024
46 of 47 checks passed
@edsiper edsiper deleted the pwhelan-fleet-fix-register-agent-from-header branch November 7, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants