-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_calyptia: retry agent registration on flush callback #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if register_retry_on_flush is set (default true), agent registration is retried on each flush callback. if set to false then registration will cause to abort the plugin initialisation. Signed-off-by: Jorge Niedbalski <[email protected]>
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 27, 2024 21:29
aee889a
to
06698b0
Compare
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 27, 2024 21:36
06698b0
to
ed8587b
Compare
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 28, 2024 10:32
ed8587b
to
ef97189
Compare
niedbalski
requested review from
pwhelan,
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
November 28, 2024 10:33
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 28, 2024 13:53
84d00f4
to
4b6637d
Compare
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 28, 2024 14:03
4b6637d
to
29e793f
Compare
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 28, 2024 14:33
29e793f
to
4f361a6
Compare
Signed-off-by: Jorge Niedbalski <[email protected]>
niedbalski
force-pushed
the
fix/register-retry-on-flush
branch
from
November 28, 2024 14:36
4f361a6
to
a19a707
Compare
patrick-stephens
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS failures unrelated - due to cprofiles: fluent/cprofiles#7
AdheipSingh
pushed a commit
to AdheipSingh/fluent-bit
that referenced
this pull request
Dec 4, 2024
* out_calyptia: retry registering agent on flush. if register_retry_on_flush is set (default true), agent registration is retried on each flush callback. if set to false then registration will cause to abort the plugin initialisation. Signed-off-by: Jorge Niedbalski <[email protected]> * custom_calyptia: cascade register_retry_on_flush variables. Signed-off-by: Jorge Niedbalski <[email protected]> --------- Signed-off-by: Jorge Niedbalski <[email protected]> Co-authored-by: Jorge Niedbalski <[email protected]> Signed-off-by: AdheipSingh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if register_retry_on_flush is set (default true, my proposal)0, agent registration is retried on each flush callback.
if set to false then registration will cause to abort the plugin initialisation.
Testing
Use with this configuration
If set to true (my proposed default)
If set to false, registration terminates the initialisation.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.