Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Detect machine_id corruption and fill out a dummy value #9690

Merged

Conversation

cosmo0920
Copy link
Contributor


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-detect-machine-is-corruption-and-fillout-dummy-value branch from f7e4226 to 3395973 Compare December 4, 2024 09:27
@cosmo0920 cosmo0920 force-pushed the cosmo0920-detect-machine-is-corruption-and-fillout-dummy-value branch from 3395973 to 40bdae6 Compare December 4, 2024 10:24
@patrick-stephens
Copy link
Contributor

patrick-stephens commented Dec 4, 2024

Can we hold off on merging this until we merge some other machine id changes related to uniqueness not being guaranteed?

#9691

@cosmo0920
Copy link
Contributor Author

Can we hold off on merging this until we merge some other machine id changes related to uniqueness not being guaranteed?

#9691

Yes, we can do. This PR has a possibility to cause a conflict for #9691. So, we should hold on for now.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-detect-machine-is-corruption-and-fillout-dummy-value branch from 1011c09 to c47d2fb Compare December 10, 2024 07:14
@cosmo0920 cosmo0920 marked this pull request as ready for review December 10, 2024 07:14
@cosmo0920 cosmo0920 added this to the Fluent Bit v3.2.3 milestone Dec 10, 2024
@edsiper edsiper merged commit bfa594c into master Dec 11, 2024
49 of 50 checks passed
@edsiper edsiper deleted the cosmo0920-detect-machine-is-corruption-and-fillout-dummy-value branch December 11, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants