opentelemetry: add Logs metadata support for JSON payload #9724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Silva <[email protected]>
This change adds support to parse and register the resources and scope metadata coming from Logs which are ingested from a JSON payload. Signed-off-by: Eduardo Silva <[email protected]>
…UnixNano Signed-off-by: Eduardo Silva <[email protected]>
edsiper
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
the new configuration option 'data_mode' allows to control what type of data the plugin pass to the callback set by the caller. By default it was always passing one log record at a time in the configured 'format'; now with 'data_mode' the user can set 'single_record' (default) or 'chunk'. When the option 'chunk' is passed, the whole binary chunk is passed to the callback as a reference (it's up to the caller to unpack and validate the content) Signed-off-by: Eduardo Silva <[email protected]>
…d body Signed-off-by: Eduardo Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the data ingestion in in_opentelemetry comes as JSON payload, the metadata is not registered. This PR adds the group record with the proper schema to solve this problem. Also it registers
spanId,traceIdandobservedTimeUnixNanoIn addition in out_opentelemetry, it removes the strict string value check of
severityTextand allows the value set originally.The unit test for in_opentelemetry has been extended to validate the group metadata and group body.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.