plugin: Detect config format and use a proper loader #9738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Unfortunately, it's hard to implement unit testing for this feature... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For classic mode and yaml mode of plugins_file parser should differ because classic mode of plugins_file has key-value pair which includes Path and the real path by contrast yaml mode of plugins_file just contains array under plugins section.
This should be caused by the difference between ini file and Yaml file syntax.
So, we need to detect the format of files when loading configurations for external plugins.
Closes #9729.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
For yaml:
plugins.yaml
For classic mode:
[SERVICE] Flush 5 Daemon Off Log_Level debug Plugins_File plugins.yaml HTTP_Server On HTTP_Listen 0.0.0.0 HTTP_Port 2020 Hot_Reload On storage.metrics On [INPUT] Name gdummy Tag dummy.local.ins1 Dummy {"compact": true, "schema": 1, "message": "ok"} # threaded on [OUTPUT] Name stdout Match *plugins.conf
For yaml:
For classic mode:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.