Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onigmo: windows: Use CMake when using MSVC #990

Closed
wants to merge 1 commit into from

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Dec 20, 2018

onigmo-cmake/CMakeLists.txt's original license is LGPL-2.0.
Can we include this LGPL-2.0-ed license file?
Is there any lincense incompatibility?


When we use MSVC, we cannot execute configure, autoconf, and make.
Instead, we should generate Visual Studio solution files via cmake.

Signed-off-by: Hiroshi Hatake [email protected]

@cosmo0920
Copy link
Contributor Author

Related: #960

@fujimotos
Copy link
Member

fujimotos commented Dec 21, 2018

We had some office discussion about this patch with @kou.

The overall conclusion was that we are better to submit this patch to
the upstream (onigmo) project, instead of maintaining a custom build
file by our hand in this repo.

@cosmo0920 Can you handle this patch as kou suggested next week?
(prob #991 too)


Side Note There's yet another way to build onigomo, which does not
require a custom build file, so the policy mentioned above should pose
no issue to the overall dev schedule.

We'll switch to the new build file once the upstream integrates it!

@cosmo0920 cosmo0920 closed this Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants