rpm: fix W: no-manual-page-for-binary #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll one more commit to fix. |
ashie
reviewed
Jun 4, 2020
| for man in `find %{buildroot} -type f -name '*.1'`; do | ||
| gzip ${man} | ||
| done | ||
| for man in `find %{buildroot} -type f -name '*.3'`; do |
There was a problem hiding this comment.
Memo:
If it's not exist, man files in gems and other bundled softwares will cause following warnings:
td-agent.x86_64: W: manpage-not-compressed gz /opt/td-agent/share/man/man3/jemalloc.3
This manual page is not compressed with the gz compression method (does not
have the gz extension). If the compression does not happen automatically when
the package is rebuilt, make sure that you have the appropriate rpm helper
and/or config packages for your target distribution installed and try
rebuilding again; if it still does not happen automatically, you can compress
this file in the %install section of the spec file.
...
Probably td-agent users won't use such man files, so we can just remove them.
But I'm not sure about it. I think compressing all man files is not so bad workaround.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install man section(1) pages and compress them.