Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the actual Object metadata when add_object_metadata is enabled #291

Closed
wants to merge 1 commit into from
Closed

Conversation

hlx98007
Copy link

@hlx98007 hlx98007 commented Oct 3, 2019

Fix issue #290

Signed-off-by: Steven Huang <[email protected]>
@ganmacs
Copy link
Member

ganmacs commented Oct 4, 2019

@hlx98007
Copy link
Author

hlx98007 commented Oct 4, 2019

@ganmacs Could you guide me on how to resolve this one? I am not too familiar with Ruby and how the CI was setup.

Since the CI test is mocking the data responses and there is no object metadata put initially in the test, I am not sure how to work on the CI part.

@repeatedly
Copy link
Member

repeatedly commented Oct 4, 2019

BTW, need new parameter because changing generated record may break existing user pipeline.

@hlx98007
Copy link
Author

hlx98007 commented Oct 4, 2019

@repeatedly If that's the case, I will close the PR because I think this need further discussion.

@hlx98007 hlx98007 closed this Oct 4, 2019
@sppwf
Copy link

sppwf commented May 12, 2021

Hi Guys,

Is there any work done over here?

Thanks
Sergiu Plotnicu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants