Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fluentd v.1.13.1 images #281

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Add Fluentd v.1.13.1 images #281

merged 2 commits into from
Jul 1, 2021

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jun 28, 2021

No description provided.

@kenhys
Add Fluentd v.1.13.1 images
528824f 
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Jun 28, 2021

Checking on windows.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 28, 2021 •
edited
Loading

Hmm, even though msys2 20210604.0.0, it got stuck again on windows.
( 20210604.0.0 is the latest version still)

It is same situation with #270 (comment)

@kenhys
Copy link
Contributor Author

kenhys commented Jun 28, 2021

@cosmo0920 Is this issue reproducible again?

@cosmo0920
Copy link
Contributor

I'm checking on it...

@cosmo0920
Copy link
Contributor

Hmm..., my docker build is also stuck:

19 gems installed
Successfully installed win32-service-2.1.6
1 gem installed
Successfully installed win32-ipc-0.7.0
1 gem installed
Successfully installed win32-event-0.6.3
1 gem installed
Successfully installed windows-pr-1.2.6
1 gem installed
*** Removed specs cache ***

@cosmo0920
Copy link
Contributor

This behavior is the same as #270 (comment).

@kenhys
Copy link
Contributor Author

kenhys commented Jun 29, 2021

Hmm, should we try self-build msys2? (if already snapshot installer is available somewhere, it is better to use it)

@stevehipwell
Copy link

Any idea on when this will be released?

@cosmo0920
Copy link
Contributor

nightly msys2 installer can be found here: https://github.com/msys2/msys2-installer/releases

@cosmo0920
Copy link
Contributor

If we use nightly installer, we should store nightly installer somewhere downloadable for reproducible Docker image buildings. (Adding tags for storing nightly msys2 installer is enough, I guess.)

@kenhys kenhys force-pushed the update-to-v1131 branch 2 times, most recently from 1f81202 to 3384cb2 Compare June 30, 2021 06:45
@kenhys
Copy link
Contributor Author

kenhys commented Jun 30, 2021

By using 20210628, it will be solved.

@kenhys kenhys force-pushed the update-to-v1131 branch from 3384cb2 to 0bb742c Compare June 30, 2021 06:55
@kenhys kenhys marked this pull request as ready for review June 30, 2021 06:56
@kenhys kenhys requested a review from cosmo0920 June 30, 2021 06:56
cosmo0920
cosmo0920 reviewed Jun 30, 2021
View reviewed changes
Dockerfile.template.erb Outdated Show resolved Hide resolved
@kenhys kenhys force-pushed the update-to-v1131 branch from 0bb742c to 85e4052 Compare July 1, 2021 01:51
@kenhys
Copy link
Contributor Author

kenhys commented Jul 1, 2021

I've fixed to use -latest version.

cosmo0920
cosmo0920 reviewed Jul 1, 2021
View reviewed changes
Dockerfile.template.erb Outdated Show resolved Hide resolved
@kenhys
Do not update msys repository by ridk install 2
509dc7e 
It cause the issue about stalling docker build on Windows.
(It seems that mass components update cause failure)

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the update-to-v1131 branch from 85e4052 to 509dc7e Compare July 1, 2021 03:06
@kenhys kenhys merged commit 3d840b8 into fluent:master Jul 1, 2021
@cosmo0920
Copy link
Contributor

🚀

@kenhys
Copy link
Contributor Author

kenhys commented Jul 1, 2021

kicked build trigger.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 1, 2021

now building windows images.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 1, 2021

done.

make DOCKERFILE=v1.13/windows-20H2 VERSION=v1.13.1-windows-20H2-1.0
make DOCKERFILE=v1.13/windows-20H2 VERSION=v1.13-windows-20H2-1
make DOCKERFILE=v1.13/windows-2004 VERSION=v1.13.1-windows-2004-1.0
make DOCKERFILE=v1.13/windows-2004 VERSION=v1.13-windows-2004-1
make DOCKERFILE=v1.13/windows-ltsc2019 VERSION=v1.13.1-windows-ltsc2019-1.0
make DOCKERFILE=v1.13/windows-ltsc2019 VERSION=v1.13-windows-ltsc2019-1

docker push fluent/fluentd:v1.13.1-windows-20H2-1.0
docker push fluent/fluentd:v1.13-windows-20H2-1
docker push fluent/fluentd:v1.13.1-windows-2004-1.0
docker push fluent/fluentd:v1.13-windows-2004-1
docker push fluent/fluentd:v1.13.1-windows-ltsc2019-1.0
docker push fluent/fluentd:v1.13-windows-ltsc2019-1

@kenhys kenhys deleted the update-to-v1131 branch July 1, 2021 07:37
@cosmo0920
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenhys @cosmo0920 @stevehipwell