Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install via Gemfile? #27

Closed
cknowles opened this issue Jun 7, 2017 · 2 comments · Fixed by #86
Closed

Install via Gemfile? #27

cknowles opened this issue Jun 7, 2017 · 2 comments · Fixed by #86

Comments

@cknowles
Copy link
Contributor

cknowles commented Jun 7, 2017

Is there any specific reason we wish to put the gem installs directly in the Dockerfile or could we use a Gemfile for each permutation?
@edsiper
Copy link
Member

edsiper commented Jun 7, 2017

no specific reason

@errm
Copy link
Contributor

errm commented Mar 19, 2018

Gemfile + Gemfile.lock would make the build process deterministic, and give us vulnerability warnings in GitHub https://help.github.com/articles/viewing-and-updating-vulnerable-dependencies-in-your-repository/

I am happy to work on this, unless there are objections?

errm added a commit to errm/fluentd-kubernetes-daemonset that referenced this issue Mar 19, 2018
@errm
Use Bundler to manage gem dependencies
9fc6df3 
* Makes builds more deterministic
* Avoids issues with plugin incompatibility with fluentd version
* Vulnerability scanning from github
* ~ moves a little closer to solving fluent#43 perhaps
* Fixes fluent#27
@errm errm mentioned this issue Mar 19, 2018
Merged
errm added a commit to errm/fluentd-kubernetes-daemonset that referenced this issue Mar 19, 2018
@errm
Use Bundler to manage gem dependencies
236dbd8 
* Makes builds more deterministic
* Avoids issues with plugin incompatibility with fluentd version
* Vulnerability scanning from github
* ~ moves a little closer to solving fluent#43 perhaps
* Fixes fluent#27
errm added a commit to errm/fluentd-kubernetes-daemonset that referenced this issue Mar 19, 2018
@errm
Use Bundler to manage gem dependencies
95b4db7 
* Makes builds more deterministic
* Avoids issues with plugin incompatibility with fluentd version
* Vulnerability scanning from github
* ~ moves a little closer to solving fluent#43 perhaps
* Fixes fluent#27
errm added a commit to errm/fluentd-kubernetes-daemonset that referenced this issue Apr 4, 2018
@errm
Use Bundler to manage gem dependencies
632d842 
* Makes builds more deterministic
* Avoids issues with plugin incompatibility with fluentd version
* Vulnerability scanning from github
* ~ moves a little closer to solving fluent#43 perhaps
* Fixes fluent#27
errm added a commit to errm/fluentd-kubernetes-daemonset that referenced this issue Apr 4, 2018
@errm
Use Bundler to manage gem dependencies
71ac6af 
* Makes builds more deterministic
* Avoids issues with plugin incompatibility with fluentd version
* Vulnerability scanning from github
* ~ moves a little closer to solving fluent#43 perhaps
* Fixes fluent#27

Signed-off-by: Ed Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Bundler to manage gem dependencies errm/fluentd-kubernetes-daemonset
3 participants
@errm @edsiper @cknowles