Skip to content

Commit

Permalink
Merge pull request #1802 from okkez/add-delimiter-pattern-to-parser-ltsv
Browse files Browse the repository at this point in the history
Add parameter delimiter_pattern to parser_ltsv
  • Loading branch information
repeatedly authored Dec 27, 2017
2 parents bc77372 + 3f79f93 commit bcd7d1a
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
9 changes: 9 additions & 0 deletions lib/fluent/plugin/parser_ltsv.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,20 @@ class LabeledTSVParser < Parser

desc 'The delimiter character (or string) of TSV values'
config_param :delimiter, :string, default: "\t"
desc 'The delimiter pattern of TSV values'
config_param :delimiter_pattern, default: nil do |value|
Regexp.compile(value[1..-2]) if value
end
desc 'The delimiter character between field name and value'
config_param :label_delimiter, :string, default: ":"

config_set_default :time_key, 'time'

def configure(conf)
super
@delimiter = @delimiter_pattern || @delimiter
end

def parse(text)
r = {}
text.split(@delimiter).each do |pair|
Expand Down
17 changes: 17 additions & 0 deletions test/plugin/test_parser_labeled_tsv.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,21 @@ def test_parse_with_null_empty_string
assert_equal record['b'], ' '
end
end

data("single space" => ["k1=v1 k2=v2", { "k1" => "v1", "k2" => "v2" }],
"multiple space" => ["k1=v1 k2=v2", { "k1" => "v1", "k2" => "v2" }],
"reverse" => ["k2=v2 k1=v1", { "k1" => "v1", "k2" => "v2" }],
"tab" => ["k2=v2\tk1=v1", { "k1" => "v1", "k2" => "v2" }],
"tab and space" => ["k2=v2\t k1=v1", { "k1" => "v1", "k2" => "v2" }])
def test_parse_with_delimiter_pattern(data)
text, expected = data
parser = Fluent::Test::Driver::Parser.new(Fluent::Plugin::LabeledTSVParser)
parser.configure(
'delimiter_pattern' => '/\s+/',
'label_delimiter' => '='
)
parser.instance.parse(text) do |_time, record|
assert_equal(expected, record)
end
end
end

0 comments on commit bcd7d1a

Please sign in to comment.