Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate out_exec_filter to v0.14 API #1048

Closed

Conversation

cosmo0920
Copy link
Contributor

I've tried to migrate out_exec_filter to v0.14 API.
Should we provide asynchronous buffered mode in this plugin?

@tagomoris
Copy link
Member

I don't think so > async
Because writing data into pipes is atomic operation, and there are no way to confirm whether it succeeded or not.

@cosmo0920
Copy link
Contributor Author

I don't think so > async
Because writing data into pipes is atomic operation, and there are no way to confirm whether it succeeded or not.

I see.

@tagomoris
Copy link
Member

I missed to comment on this change: can you use child_process plugin helper for external process?

@tagomoris
Copy link
Member

Hmm, I found there are some difficult points with child_process plugin helper. So I'll add following fixes for it.

@tagomoris tagomoris self-assigned this Jul 11, 2016
@cosmo0920
Copy link
Contributor Author

some difficult points

I've found that several difficult points for now:

  • child_process helper does not have a functionality to distribute output into number of N processes
  • child_process helper does not have a functionality to handle resident processes

@tagomoris
Copy link
Member

#1297 does what this pull-request did. Let me close this now.

@tagomoris tagomoris closed this Nov 8, 2016
@cosmo0920 cosmo0920 deleted the migrate-v0.14-api-out_exec_filter branch November 9, 2016 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants