Fix a bug not to use plugin root directory for buffer path even if configured correctly #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigured correctly.
|
@repeatedly could you review this bug fix? |
repeatedly
reviewed
Jan 11, 2017
| @@ -37,6 +37,24 @@ def create_driver(conf = CONFIG) | |||
| assert_equal :gzip, d.instance.instance_eval{ @compress_method } | |||
| end | |||
|
|
|||
| test 'using root_dir for buffer path' do | |||
There was a problem hiding this comment.
Does test_out_file have tests for buffer_conf['path'] = conf['path'] || '/tmp/dummy_path' line?
There was a problem hiding this comment.
It's just configuration error for config_param :path (in out_file), so it's clear that out_file raises configuration error for missing path...
But anyway, i added it.
|
Can I merge this? |
|
yes |
tagomoris
deleted the
fix-not-to-use-plugin-root-dir-in-out_file-buffer-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1408.