Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "string_list" type to get list of strings #874

Closed
wants to merge 1 commit into from

Conversation

tagomoris
Copy link
Member

  • it's very common case for fluentd plugins
  • "array" is useful, but it can get various types for values
  • this type should support 2 kind of formats at once:
    • comman-separated string values to make input data simple
    • JSON-format arrays for values with comma

This type definition make it possible to reduce # of self-implementation of str.split... by 3rd party plugins

* it's very common case for fluentd plugins
* "array" is useful, but it can get various types for values
* this type should support 2 kind of formats at once:
  * comman-separated string values to make input data simple
  * JSON-format arrays for values with comma

This type definition make it possible to reduce # of self-implementation of `str.split`... by 3rd party plugins
@tagomoris
Copy link
Member Author

Another proposal is to make :array to support comma-separated values with type option to support lists of various kind of types.

@sonots
Copy link
Member

sonots commented Mar 31, 2016

I am 👍 for :array with type because increasing number of types makes things be messy such as string_list, integer_list....

@tagomoris
Copy link
Member Author

I added exclusive proposal as #875

@repeatedly repeatedly closed this Apr 1, 2016
@repeatedly
Copy link
Member

Almost maintainers prefer #875 so closed.

@tagomoris tagomoris deleted the type-string-list branch May 17, 2016 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants