Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSI FUSE Recovery #2747

Merged

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Fix CSI FUSE Recovery. More details pls see #2719 .

This PR skip checking FUSE containers' restart and keep check /proc/self/mountinfo to find broken mount points in a loop mannner. This ensures any broken FUSE mount points will be eventually found and recoverd after a short period.

Ⅱ. Does this pull request fix one issue?

fixes #2719

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
61.5% 61.5% Duplication

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #2747 (8b2d1fe) into master (5e6e712) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8b2d1fe differs from pull request most recent head d5135b2. Consider uploading reports for the commit d5135b2 to get more accurate results

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         382      382              
  Lines       22042    21992      -50     
==========================================
- Hits        14891    14856      -35     
+ Misses       5404     5392      -12     
+ Partials     1747     1744       -3     
Impacted Files Coverage Δ
pkg/csi/recover/recover.go 64.76% <100.00%> (-1.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zwwhdls
Copy link
Member

zwwhdls commented Mar 16, 2023

LGTM

@cheyang cheyang requested a review from zwwhdls March 17, 2023 13:50
@zwwhdls
Copy link
Member

zwwhdls commented Mar 20, 2023

/lgtm

@zwwhdls
Copy link
Member

zwwhdls commented Mar 20, 2023

/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, zwwhdls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 09fabaf into fluid-cloudnative:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CSI failed to recover FUSE mount point for AlluxioRuntime
3 participants