Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default master journal type setting #3281

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix default master journal type setting #3281

merged 1 commit into from
Jun 13, 2023

Conversation

VincentLeeMax
Copy link
Contributor

Ⅰ. Describe what this PR does

In default setting, the alluxio.master.journal.type will set to UFS, causing the HA mode fail. Now we change the default setting according to the master replicas.

Ⅳ. Describe how to verify it

Deploy a HA alluxio dataset, delete the leading master pod, you will see:

  • Without this commit, the leading master will always be master-0 if it exists, and the workers will lost when the old leading master restart.
  • With the commit, everything works well.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 12, 2023

Hi @VincentLeeMax. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

cheyang
cheyang approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Jun 12, 2023
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Collaborator

cheyang commented Jun 12, 2023

@VincentLeeMax could you please fix DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/3281/checks?check_run_id=14182631765

cheyang
cheyang reviewed Jun 12, 2023
View reviewed changes
pkg/ddc/alluxio/transform_optimization.go
@@ -66,7 +66,11 @@ func (e *AlluxioEngine) optimizeDefaultProperties(runtime *datav1alpha1.AlluxioR
setDefaultProperties(runtime, value, "alluxio.user.file.passive.cache.enabled", "false")
setDefaultProperties(runtime, value, "alluxio.user.block.avoid.eviction.policy.reserved.size.bytes", "2GB")
setDefaultProperties(runtime, value, "alluxio.master.journal.folder", "/journal")
setDefaultProperties(runtime, value, "alluxio.master.journal.type", "UFS")
if value.Master.Replicas > 1 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you please add unit test for this change? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you please add unit test for this change? Thanks.

I don't know which file should the unit test write to, could you tell me?

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #3281 (49296fa) into master (72a6426) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

❗ Current head 49296fa differs from pull request most recent head d2c2f84. Consider uploading reports for the commit d2c2f84 to get more accurate results

@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   65.48%   65.47%   -0.01%     
==========================================
  Files         397      397              
  Lines       23170    23173       +3     
==========================================
  Hits        15173    15173              
- Misses       6214     6215       +1     
- Partials     1783     1785       +2
Impacted Files Coverage Δ
pkg/ddc/alluxio/transform_optimization.go 82.60% <25.00%> (-1.57%) ⬇️

@fluid-e2e-bot fluid-e2e-bot bot merged commit 307f8e2 into fluid-cloudnative:master Jun 13, 2023
cheyang pushed a commit to cheyang/fluid that referenced this pull request Jun 14, 2023
@VincentLeeMax @cheyang
fix default master journal type setting (fluid-cloudnative#3281)
003281c
cheyang pushed a commit to cheyang/fluid that referenced this pull request Jun 14, 2023
@VincentLeeMax @cheyang
fix default master journal type setting (fluid-cloudnative#3281)
a2438bd 
Signed-off-by: cheyang <[email protected]>
fluid-e2e-bot bot pushed a commit that referenced this pull request Jun 28, 2023
@cheyang @VincentLeeMax
fix default master journal type setting (#3281) (#3291)
3cabcf1 
Signed-off-by: cheyang <[email protected]>
Co-authored-by: VincentLeeMax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels
approved lgtm needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLeeMax @cheyang